Skip to content

Fix "Can't compare with units and without." exception#584

Merged
eyal0 merged 1 commit intopcb2gcode:masterfrom
eyal0:milldrilldiatest_units
May 24, 2021
Merged

Fix "Can't compare with units and without." exception#584
eyal0 merged 1 commit intopcb2gcode:masterfrom
eyal0:milldrilldiatest_units

Conversation

@eyal0
Copy link
Copy Markdown
Contributor

@eyal0 eyal0 commented May 24, 2021

Enabling milldrill-diameter and min-milldrill-hole-diameter
makes the program abort with the following exception:

Exporting milldrill... terminate called after throwing an instance of 'comparison_exception'
what(): Can't compare with units and without.

This patch fixes it.

Signed-off-by: Nicola Di Lieto nicola.dilieto@gmail.com

@ndilieto @eyal0
Fix "Can't compare with units and without." exception
dba66d2 
Enabling milldrill-diameter and min-milldrill-hole-diameter
makes the program abort with the following exception:

> Exporting milldrill... terminate called after throwing an instance of 'comparison_exception'
>   what():  Can't compare with units and without.

This patch fixes it.

Signed-off-by: Nicola Di Lieto <nicola.dilieto@gmail.com>
@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented May 24, 2021

This fixes #581

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 24, 2021

Coverage Status

Coverage increased (+0.04%) to 69.294% when pulling dba66d2 on eyal0:milldrilldiatest_units into ed67bef on pcb2gcode:master.

@eyal0 eyal0 merged commit 598105e into pcb2gcode:master May 24, 2021
@eyal0 eyal0 deleted the milldrilldiatest_units branch May 24, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyal0 @coveralls @ndilieto