Merged
Conversation
According to the [Gerber Format Specification](https://www.bosco.co.za/DownloadDocs/The_Gerber_Format_Specification.pdf) section 4.6.1, a contour may only be ended by a D02 or G37 when the contour is closed. For example, a rectangle must have four line segments, not three. EasyEDA seems to be making shapes missing a line segment and assumes that interpreters will close the contour. `pcb2gcode` can support this by checking that the region is closed. If not, add a point at the end which matches the first point so that the contour is closed. This fixes pcb2gcode#577
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Gerber Format
Specification
section 4.6.1, a contour may only be ended by a D02 or G37 when the
contour is closed. For example, a rectangle must have four line
segments, not three.
EasyEDA seems to be making shapes missing a line segment and assumes
that interpreters will close the contour.
pcb2gcodecan supportthis by checking that the region is closed. If not, add a point at
the end which matches the first point so that the contour is closed.
This fixes #577