Add option to apply mirroring to the Y axis#572
Add option to apply mirroring to the Y axis#572eyal0 merged 6 commits intopcb2gcode:masterfrom vicencb:master
Conversation
|
Excellent work. I'll add some integration tests so that we can look visually to confirm that everything is working as expected. |
This has marks indicating the true zero and some other spots useful to checking alignment.
|
I see a little bit of confusion around positive and negative. In KiCad, positive x is to the right and positive y is downward. But in gerbv, positive x is to the right and positive y is upward. Since we're using gerbv as a library, I think that we'll do it the gerbv way. Also it makes the code make more sense so that the handling of x and the handling of y look similar. Here's my test image: If I set the axis to be y and the mirror-axis to be -0.5inches, those little marks on the right side line up properly, so that seems great! I also checked that it works with the tiling features enabled. Great! The tests should improve coverage. |
|
Hi Eyal, Regards, |

Hi,
this change adds the option to appy the mirroring to the Y axis instead of the X axis.
Regards,
Vicente.