fix: Use a spike mask instead of line intersections.#561
Merged
eyal0 merged 1 commit intopcb2gcode:masterfrom Mar 1, 2021
Merged
fix: Use a spike mask instead of line intersections.#561eyal0 merged 1 commit intopcb2gcode:masterfrom
eyal0 merged 1 commit intopcb2gcode:masterfrom
Conversation
Collaborator
Checking for intersections fails sometimes when the milled line matches the voronoi boundary because the spike doesn't have an inner path against which to make an intersection. This can cause the spike to dig into the trace a little. Rather than check if a spike intersects a previous milling line, just mask the spikes by the area of the previous milling. This should do the same work, more or less, but without the pathological case when the previous milling paths match the current milling path at some or all of the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for intersections fails sometimes when the milled line
matches the voronoi boundary because the spike doesn't have an inner
path against which to make an intersection. This can cause the spike
to dig into the trace a little.
Rather than check if a spike intersects a previous milling line, just
mask the spikes by the area of the previous milling. This should do
the same work, more or less, but without the pathological case when
the previous milling paths match the current milling path at some or
all of the path.