API version 2.1.0 See https://docs.patch.io/#/changelog for changes #73
Conversation
309814c to
4c3fe36
Compare
pcothenet
left a comment
There was a problem hiding this comment.
Great work. One concern about the OpenAPI version comment that looks manual and not desired.
4c3fe36 to
11b4ec7
Compare
holtbp
left a comment
There was a problem hiding this comment.
Sharing some thoughts that feel very late
|
Those are some great thoughts! We should definitely go over what we want the response to look like in the case of vintage years for v3, but I would think that either having a top-level In the meantime, should we remove "deprecated" tags since we'll still have support for these fields? |
Yeah, that sounds good. |
8f1e9a4 to
3408064
Compare
| ) | ||
|
|
||
| expect(create_estimate_response.data.type).to eq 'shipping' | ||
| expect(create_estimate_response.data.type).to eq 'ecommerce' |
There was a problem hiding this comment.
We're now re-routing to the ecommerce endpoint: https://github.com/patch-technology/patch/pull/5588
3408064 to
4353f65
Compare
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - Adds optional `vintage_start_year` and `vintage_end_year` field to `order` creation | ||
| - Adds optional `vintage_start_year` and `vintage_end_year` field to `order_line_item` create and update |
4353f65 to
8b5243d
Compare
| - Adds `vintage_start_year` and `vintage_end_year` fields to `order` response | ||
| - Adds `vintage_start_year` and `vintage_end_year` fields to `order_line_item` response | ||
| - Adds optional `carrier_scac` field to `Patch::Estimate.create_road_shipping_estimate` method | ||
| - Deprecates `Patch::Estimate.create_shipping_estimate` in favor of `Patch::Estimate.create_ecommerce_estimate` |
There was a problem hiding this comment.
Note that there doesn't seem to be a related change in the code. Is it just behind the scenes?
There was a problem hiding this comment.
I believe it's in relation to https://github.com/patch-technology/patch/pull/5588. @holtbp merged his change that fixes the integration tests and we spoke offline on updating the docs
What
API version 2.1.0. See https://docs.patch.io/#/changelog for changes
Why
Version 2.1.0 adds support for
vintage_start_yearandvintage_end_yearfor ordersvintage_start_yearandvintage_end_yearfor order line itemsvintage_start_yearandvintage_end_yearfor inventorycarrier_scacfield toPatch::Estimate.create_road_shipping_estimatSDK Release Checklist
If endpoints were removed, did you manually remove the corresponding files? (this should be rare)For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?