-
Notifications
You must be signed in to change notification settings - Fork 964
Include mandatory NSLocationUsageDescription on macOS #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rschiang
wants to merge
1,714
commits into
overtake:master
Choose a base branch
from
rschiang:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Telegram-Mac/Info.plist # TelegramShare/Info.plist
Starting from macOS Big Sur, location usage description has been enforced on new apps. On macOS, however, the `Info.plist` property key the system resorts to is `NSLocationUsageDescription` instead of `NSLocationWhenInUseUsageDescription`. This commit fixes that.
|
|
Nampro79
approved these changes
Jan 25, 2022
9aa8690 to
579cebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from macOS Big Sur, location usage description has been enforced on new apps. Apps that fail to include the aforementioned description would cause an outright crash (thus the issue encountered in #655).
stderrlog shows the following error when Telegram.app attempts to access Location for the first time:It is true that the current
Info.plistalready containsNSLocationWhenInUseUsageDescription, which is the said property key for iOS. However, as documented by Apple, macOS uses a different property key calledNSLocationUsageDescription:And in
NSLocationUsageDescription’s documentation:This pull request should fix the issue.