Release v1 #25
Merged
Release v1 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
=======================================
+ Coverage 89.7% 90.1% +0.3%
=======================================
Files 7 7
Lines 293 293
Branches 52 52
=======================================
+ Hits 263 264 +1
Misses 17 17
+ Partials 13 12 -1
|
klette
approved these changes
Nov 25, 2021
Member
klette
left a comment
There was a problem hiding this comment.
Sure, let's rather do a quick 2.0 if we figure out that we want to do the serializer plugins differently once we get back to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't had any issues running this over the last few months, and while the built-in image-serializer and 100% test coverage would be a nice addition, it's not really something we would need before considering the parser feature-complete wrt. the portable text spec.
Since we're not really spending a lot of time on this presently, and there's no clear reason to suggest it's not usable, I suggest we just bump this to v1.0.0.
I've seen the repo mentioned in the sanity-slack once or twice the last few weeks, and keeping the package at
v0.0.xseems like it would discourage use unnecessarily 🙂What do you think @klette?