Fix sync error when libp2p nodes are disconnected between reception of head and persistence of entry #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienmalard
added a commit
to reseau-constellation/ipa
that referenced
this pull request
Nov 14, 2025
Member
|
@haadcode This looks good to me. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error caused by libp2p node disconnection between the reception of a database entry and the persistence of the same entry in the IPFS blockstore.
This is caused by the following chain of events:
joinEntryon the log.oplogStore.addVerified.addVerifiedthen callsawait _entries.persist(hash)on the IPFS blockstore. If, by now, the underlying libp2p nodes are disconnected, the call topersiston the IPFS blockstore will hang, even if the OrbitDB node has already received the full entry, because this entry has not yet been added to the local IPFS node and the call topinwill attempt to retrieve the entry by its hash from the wider IPFS network, where it is no longer available.This pull request fixes the issue with two changes:
log.js,oplogStore.addHeadis now called beforeoplogStore.addVerifiedoplog-store.js,addHeadnow explicitly adds the new head to the_entriesstorage.