Ensure that SimStore always saves movescheme #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 81.27% 81.30% +0.02%
==========================================
Files 139 139
Lines 15149 15150 +1
==========================================
+ Hits 12313 12317 +4
+ Misses 2836 2833 -3
Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Fri 04 Jun 19:00 GMT (15:00 my local). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an email report from @gyorgy-hantal. It seems that SimStore was not saving the move scheme in the rare case that all steps fail due to maximum length/NaN. This seems to be because of a difference in SimStore allowing you to stash several steps for saving, whereas netcdfplus immediately saves after each step.
This PR also introduces a (not well-tested)
unpatchmethod to undo the SimStore monkey patches. This will mainly be useful in testing.