Skip to content

fix: prevent panic on double close of data channel in batcher #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
buvidk1234 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent panic on double close of data channel in batcher #3654

buvidk1234 wants to merge 1 commit into from

Conversation

@buvidk1234
Copy link

@buvidk1234 buvidk1234 commented Jan 6, 2026

  • Add alreadyClosed flag to track if data channel was closed unexpectedly
  • Skip closing data channel in defer if already closed
  • Add unit test TestBatcher_UnexpectedChannelClose to verify the fix

Fixes #3653

@buvidk1234
fix: prevent panic on double close of data channel in batcher
3bcb1ce 
- Add alreadyClosed flag to track if data channel was closed unexpectedly
- Skip closing data channel in defer if already closed
- Add unit test TestBatcher_UnexpectedChannelClose to verify the fix
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026 •
edited
Loading

🤖 All Contributors have signed the CLA.
The signed information is recorded here
Posted by the CLA Assistant Lite bot.

@buvidk1234
Copy link
Author

buvidk1234 commented Jan 6, 2026

I have read the CLA Document and I hereby sign the CLA

OpenIM-Robot added a commit to OpenIM-Robot/cla that referenced this pull request Jan 6, 2026
@OpenIM-Robot
@buvidk1234 has signed the CLA in openimsdk/open-im-server#3654
b25f89f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Batcher scheduler may panic on double close of data channel

1 participant

@buvidk1234