Fix #27961: Support reproducible builds by making host system version optional #27979
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion optional Add BUILD_INFO_SKIP_SYSTEM_VERSION option to exclude the host kernel version from build outputs, enabling reproducible builds across systems with different kernel versions. Changes: - Modified CMakeLists.txt to conditionally include CMAKE_HOST_SYSTEM_VERSION in the build platform status based on BUILD_INFO_SKIP_SYSTEM_VERSION flag - Updated 3rdparty/tbb/CMakeLists.txt to set TBB_HOST_VERSION conditionally - Modified 3rdparty/tbb/version_string.ver.cmakein to use the new variable When BUILD_INFO_SKIP_SYSTEM_VERSION=ON is set, the host system version is excluded from both the CMake status output and the TBB version strings, producing identical binaries on equivalent build systems regardless of kernel version differences. Default behavior is unchanged (version included) for backward compatibility. Fixes opencv#27961
itsrayeedscodespace
left a comment
There was a problem hiding this comment.
Doesn't seem to have any conflicts, no?
|
That is correct. There is no conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #27961 by adding support for reproducible builds through a new CMake option that excludes the host kernel version from build outputs.
Changes
Behavior
Default (Backward Compatible)
When is not set (default), the behavior is unchanged - host system version is included in both CMake status output and TBB version strings.
Reproducible Builds Mode
When is set, the host kernel version is excluded from build outputs, producing identical binaries on equivalent build systems regardless of kernel version differences.
Testing
Users can verify the fix by:
This follows the same pattern as the existing
BUILD_INFO_SKIP_TIMESTAMPoption, maintaining consistency with OpenCV's build configuration approach.Fixes #27961