Skip to content

core: remove std::vector type-punning in _InputArray/_OutputArray #27870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 4.x
Choose a base branch
from
Open

core: remove std::vector type-punning in _InputArray/_OutputArray #27870

wants to merge 6 commits into from
+450 −135

Conversation

@akchaud5
Copy link

@akchaud5 akchaud5 commented Oct 5, 2025 •
edited by asmorkalov
Loading

Fixes #26289

  • Introduce internal type-safe ops for std::vector and std::vector<std::vector> with a thread-local registry.
  • Register ops in vector-based _InputArray/_OutputArray/_InputOutputArray constructors and rawIn/rawOut/rawInOut.
  • Replace unsafe type-punning in matrix_wrap.cpp with ops-based size/data/resize.
  • No ABI change; behavior preserved without UB on new libc++ vector representations.

Build: validated core-only build succeeds.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@akchaud5
core: remove std::vector type-punning in _InputArray/_OutputArray (fixes
cd0714f 
 opencv#26289)

- Introduce internal type-safe ops for std::vector<T> and std::vector<std::vector<T>> with a thread-local registry.
- Register ops in vector-based _InputArray/_OutputArray/_InputOutputArray constructors and rawIn/rawOut/rawInOut.
- Replace unsafe type-punning in matrix_wrap.cpp with ops-based size/data/resize.
- No ABI change; behavior preserved without UB on new libc++ vector representations.

Build: validated core-only build succeeds.
@akchaud5
core: export registry symbols for linux shared builds (precommit fix)
c474218
@akchaud5
core: avoid type check on outer resize for vector-of-vectors in Outpu…
14f8d50 
…tArray::create()
@akchaud5 akchaud5 force-pushed the core-inputarray-vector-ops-26289-clean branch from 9b906e5 to 14f8d50 Compare October 6, 2025 02:59
@asmorkalov asmorkalov changed the title core: remove std::vector type-punning in _InputArray/_OutputArray (fi… core: remove std::vector type-punning in _InputArray/_OutputArray Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

category: core pr: Discussion Required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_InputArray and its derivatives need a clean-up

2 participants

@akchaud5 @asmorkalov