OBPIH-6735 fix duplicate key errors on multiple rows in record stock with the sa… #5703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewaterman
commented
Jan 8, 2026
| * This class acts like a simplified InventoryItem. We'd like to one day refactor InventoryItem to either use | ||
| * or be more like this class, but for now this class is a simple POJO. | ||
| */ | ||
| class ProductLot { |
Member
Author
There was a problem hiding this comment.
Hilighting this class in case there are any opinions
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5703 +/- ##
============================================
+ Coverage 9.12% 9.83% +0.71%
- Complexity 1170 1375 +205
============================================
Files 701 731 +30
Lines 45281 46128 +847
Branches 10851 11009 +158
============================================
+ Hits 4131 4537 +406
- Misses 40497 40886 +389
- Partials 653 705 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me new lot
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6735
Description: We were getting errors on record stock if you add two or more rows with a lot number that does not yet exist. This is because we were looping through the rows, creating the items, and since both rows were in the same transaction, they both try to create the same lot. The fix was to first collect all unique lots from all rows and then get or create them in bulk.