Make LambdaInstance release dead sandbox when it OOMs #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states, when a sandbox OOMs, it will stay attached to the LambdaInstance.
This might get cleared up by the evictor if we get lucky, but all requests routed to this will fail until it happens.
Reproduction steps:
for mem in 5 1024 5; do curl -sS -X POST localhost:5000/run/<fn_name> -d '{"mem": '$mem'}'; echo; done;. We find that the third invocation fails because the second failed.for mem in 5 1024 5; do curl -sS -X POST localhost:5000/run/<fn_name> -d '{"mem": '$mem'}'; echo; done;. We find that the third invocation succeeds even though the second failed.