This repository was archived by the owner on Oct 1, 2025. It is now read-only.
feat: try to detect global mixins adding meta info #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
=========================================
- Coverage 99.84% 99.1% -0.74%
=========================================
Files 33 33
Lines 659 674 +15
Branches 198 204 +6
=========================================
+ Hits 658 668 +10
- Misses 1 4 +3
- Partials 0 2 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: make sure that beforeMount hook to hydrate from ssr is only added once (disclaimer, havent been able to trigger an issue with this manually tough)
Recently there have been some issues due to third party libs adding a global mixin which sets meta information. Since v2.3 that is not the recommended approach anymore (using addApp is). This pr tries to detect if a global mixin adding keyName was used and logs a warning about that