packages/nuxt/test/scan-components.test.ts (2)

89-241: Test expectations correctly updated to include declarationPath field.

The additions properly reflect the new Component interface shape. Each declarationPath matches the component file path, which correctly validates the default fallback behavior when no custom declarationPath is configured.

However, consider adding test coverage for the primary use case where declarationPath differs from filePath. This would validate the feature's intended functionality per issue #33374.

Add a test directory configuration with a custom declarationPath to validate the feature:

{
  path: rFixture('components'),
  extensions: ['vue'],
  pattern: '**/*.{vue,}',
  ignore: ['**/*.stories.{js,ts,jsx,tsx}', '**/*{M,.m,-m}ixin.{js,ts,jsx,tsx}', '**/*.d.ts'],
  transpile: false,
  declarationPath: rFixture('types/custom-declarations.d.ts'), // Custom declaration path
}

Then verify that scanned components from this directory use the custom declarationPath rather than their filePath.

---

247-253: Consider verifying both filePath and declarationPath together.

The test deletes filePath before comparison, which prevents verifying the relationship between filePath and declarationPath. Since the PR introduces logic to fall back to filePath when declarationPath is not provided, consider asserting both properties to ensure the fallback behaviour works correctly.

Alternatively, add a separate assertion to verify the relationship:

// Verify declarationPath defaults to filePath when not explicitly set
for (const c of scannedComponents) {
  if (!dirs.find(d => d.declarationPath)) {
    expect(c.declarationPath).toBe(c.filePath)
  }
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/nuxt/test/scan-components.test.ts (1)

86-241: Test data correctly updated for default behaviour.

The declarationPath field has been properly added to all component entries, demonstrating the default fallback behaviour where declarationPath equals filePath. The test coverage spans various component scenarios including islands, globals, and client/server modes.

Consider adding a test case where declarationPath differs from filePath to verify the core feature—using an explicit declaration path separate from the source file. This would ensure the feature works as intended when consumers actually specify a different declaration path.

Example test configuration:

{
  path: rFixture('components'),
  declarationPath: rFixture('types/components'),
  // ... other config
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro