-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: migrate gitpod to ona #33159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate gitpod to ona #33159
Conversation
|
|
@nuxt/kit
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
WalkthroughRemoved the legacy Gitpod configuration file Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.gitpod/automations.yaml (5)
5-7: Make the long‑running dev server a Service, keep install/prepare as a Task.
pnpm playis likely a long‑running server. Best practice: model it as a Service and keep setup as a short‑lived Task, improving observability and lifecycle control.Apply this rewrite:
-tasks: - install-and-dev: - name: Install dependencies and start dev - command: | - pnpm install - pnpm dev:prepare - pnpm play - triggeredBy: - - postDevcontainerStart - - manual +services: + dev: + name: Nuxt Dev Server + commands: + start: pnpm play + triggeredBy: + - postDevcontainerStart +tasks: + setup: + name: Install dependencies and prepare workspace + command: | + pnpm install --frozen-lockfile + pnpm dev:prepare + triggeredBy: + - postDevcontainerStart + - manualNote: Services are intended for long‑running processes; Tasks are short‑lived and one‑off. (ona.com)
8-10: Consider adding postEnvironmentStart to cover runner resume scenarios.On AWS runners, resumes may not re‑trigger
postDevcontainerStart. If you want setup to re‑run on every environment start/resume, includepostEnvironmentStart.Example:
triggeredBy: - - postDevcontainerStart + - postDevcontainerStart + - postEnvironmentStart - manualSource: (ona.com)
5-6: Lock installs for reproducibility.Use
pnpm install --frozen-lockfileto prevent drift from the committed lockfile.
1-10: Replicate old port 3000 “open-preview” behaviour via devcontainer.json.Since the Classic
portsconfig is removed, add this to.devcontainer/devcontainer.jsonto auto‑forward 3000 and open a preview/browser:{ "appPort": [3000], "portsAttributes": { "3000": { "onAutoForward": "openPreview" } } }Sources: (code.visualstudio.com, git.lance1416.com)
10-10: Add a newline at end of file.Fixes the YAML lint error.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.gitpod.yml(0 hunks).gitpod/automations.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- .gitpod.yml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.gitpod/automations.yaml
[error] 10-10: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: code
🔇 Additional comments (1)
CodSpeed Performance ReportMerging #33159 will not alter performanceComparing Summary
Footnotes |
|
Thanks @danielroe . 😊 |
Gitpod is now Ona. (https://ona.com/stories/gitpod-is-now-ona)
This is the migration setup. (https://ona.com/docs/ona/configuration/migrate-from-classic)