-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
test: simplify test-cli-node-options-docs
#61006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:test-cli-node-options-docs
Dec 11, 2025
Merged
test: simplify test-cli-node-options-docs
#61006
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:test-cli-node-options-docs
Dec 11, 2025
+19
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61006 +/- ##
==========================================
- Coverage 92.23% 88.53% -3.71%
==========================================
Files 343 703 +360
Lines 139073 208432 +69359
Branches 22251 40195 +17944
==========================================
+ Hits 128277 184534 +56257
- Misses 10569 15905 +5336
- Partials 227 7993 +7766 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Dec 9, 2025
Collaborator
cjihrig
approved these changes
Dec 10, 2025
ErickWendel
approved these changes
Dec 10, 2025
Collaborator
|
Landed in 029ebac |
aduh95
added a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #61006 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 12, 2026
PR-URL: #61006 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version is hard to reason about with non-const variables, and use of
=== false. Also we need a change for #60906 to correctly detectHAVE_SQLITEin the code.