Skip to content

buffer: add {read|write}Big[U]Int64{BE|LE} methods#19691

Closed
seishun wants to merge 12 commits intonodejs:masterfrom
seishun:buffer64
Closed

buffer: add {read|write}Big[U]Int64{BE|LE} methods#19691
seishun wants to merge 12 commits intonodejs:masterfrom
seishun:buffer64

Conversation

@seishun
Copy link
Copy Markdown
Contributor

@seishun seishun commented Mar 30, 2018 •
edited
Loading

This is a resurrection of #15152, this time with BigInts.

The functions writeBigU_Int64LE and writeBigU_Int64BE look so terrible because setting Uint8Array values to BigInt is disallowed by the spec. I submitted an issue about it in tc39/proposal-bigint#137. Please 👍 it or whatever if you agree.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@targos targos targos left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+3 more reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@TimothyGu TimothyGu TimothyGu approved these changes

@devsnek devsnek devsnek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.