Added custom hostname support to the OPCUA Discovery Server #1023
Conversation
|
|
1f58db1 to
5e26575
Compare
6a9a170 to
d9492e4
Compare
bbf625a to
8328c4d
Compare
bf76eee to
1b97628
Compare
72e61b9 to
cb01c1a
Compare
3e9da89 to
8166185
Compare
|
ALthough I understand the need to be able to access the LocalDiscovery server under different hostname. I don't think it is appropriate to use the OPCUAServerEndpointOptions interface to convey, this information; OPCUAServerEndpointOptions is used for fullblown servers and contains options that are irrelevant for LDS only servers. We will need to find a more subtil approach. |
erossignon
left a comment
There was a problem hiding this comment.
Pleas also add relevant units test to verify that the alternate hostnames are properly exposed and present in the auto-generated certificate.
| endPoint.addStandardEndpointDescriptions({ | ||
| securityModes: this._primaryEndpoint.securityModes, | ||
| securityPolicies: this._primaryEndpoint.securityPolicies, | ||
| disableDiscovery: this._primaryEndpoint.disableDiscovery, |
There was a problem hiding this comment.
Not sure disableDiscovery is relevant for a ... discovery server
| } | ||
|
|
||
| export interface OPCUADiscoveryServerOptions extends OPCUABaseServerOptions { | ||
| export interface OPCUADiscoveryServerOptions extends OPCUABaseServerOptions, OPCUAServerEndpointOptions { |
There was a problem hiding this comment.
I would rather add a àlthername hostname property to the OPCUADiscoveryServerOptions interface
OPCUAServerEndpointOptions contains too many options that are not relevant to LDS server.
|
|
||
| super(options); | ||
|
|
||
| this._primaryEndpoint = { |
There was a problem hiding this comment.
super.options already contains a copy of the options parameter.
No need to duplicate here .
51c1ece to
e341f59
Compare
In the project I work on currently we have a LDS deployed on a Kubernetes cluster in the cloud. When trying to register a server on it, every time the LDS would take its local hostname, a name that cannot be resolved by any server who's on a different network.
This pull request adds a way to define custom hostnames to the OPCUADiscoveryServer class in the same manner the OPCUAServer can. Now you can pass a custom hostname that does get resolved outside of the network.