QUIC: prevented BIO leak in case of error. #348
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluknet
approved these changes
Nov 25, 2024
Contributor
pluknet
left a comment
There was a problem hiding this comment.
SSL_set0_rbio() and SSL_set0_wbio() have portability issues, so using SSL_set_bio() is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of
wbioallocation error,rbioleaked.An alternative solution could be calling
SSL_set0_rbio()andSSL_set0_wbio()instead ofSSL_set_bio().The suggested change is a bit simpler though.