Reduce some 'in' #276321
Merged
Reduce some 'in' #276321
+32
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the chat codebase to replace manual type checking with proper type guard functions and existing helpers, improving type safety and code maintainability. The changes address ESLint violations related to the @typescript-eslint/no-unsafe-member-access rule.
Key Changes
- Introduces type guard functions (
isChatFollowup,isIChatViewViewContext,isIChatResourceViewContext) to replace manual property existence checks - Replaces manual type checks with existing type guard functions (
isLocation,isITextModel) - Simplifies conditional logic by removing unnecessary property existence checks
- Removes several files from the ESLint exception list after fixing violations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/chatService.ts |
Adds isChatFollowup type guard function to check if an object is an IChatFollowup |
src/vs/workbench/contrib/chat/browser/chat.ts |
Adds isIChatViewViewContext and isIChatResourceViewContext type guard functions for chat widget view contexts |
src/vs/workbench/contrib/chat/browser/chatWidget.ts |
Refactors to use new type guards instead of manual 'property' in object checks |
src/vs/workbench/contrib/chat/browser/chatListRenderer.ts |
Uses isChatFollowup type guard and simplifies height access by removing unnecessary 'currentRenderedHeight' in element check |
src/vs/workbench/contrib/chat/browser/chatInputPart.ts |
Replaces manual type checking with isLocation helper and removes unused Range import |
src/vs/workbench/contrib/chat/browser/chatFollowups.ts |
Simplifies tooltip logic by removing unnecessary 'tooltip' in followup check |
src/vs/workbench/contrib/chat/browser/chatEditorInput.ts |
Changes from 'data' in this.options.target to this.options.target.data for checking target data |
src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts |
Uses isITextModel type guard instead of manual 'uri' in model check |
eslint.config.js |
Removes 7 chat-related files from the unsafe member access exception list |
DonJayamanne
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#276071