Clear Name, Source, and Commandline from Profiles.Defaults #19225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
Aug 7, 2025
DHowett
approved these changes
Aug 7, 2025
Member
Author
|
Currently fixing the tests. I also just noticed that Personally, I think that's the right move, but curious about your thoughts. Let me know! |
Member
|
You will need to figure out how to test the icon path fallback behavior if you don't allow that |
DHowett
requested changes
Aug 7, 2025
DHowett
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Name, Source, and Commandline profile settings should not be allowed to be set on the Profiles.Defaults object. This just enforces that by clearing them (as is done with Guid).
These profile settings are omitted from the settings UI's profile defaults page.
Closes #19202