Skip to content

fix: Save a reference to created tasks, to avoid tasks disappearing #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tracyboehrer merged 3 commits into from
Jan 26, 2024
Merged

fix: Save a reference to created tasks, to avoid tasks disappearing #2005

tracyboehrer merged 3 commits into from
Jan 26, 2024

Conversation

@anio
Copy link
Contributor

@anio anio commented Jun 28, 2023 •
edited by tracyboehrer
Loading

#minor

This change saves references for created tasks to avoid tasks disappearing.

Save a reference to the result of this function, to avoid a task disappearing mid-execution. The event loop only keeps weak references to tasks. A task that isn’t referenced elsewhere may get garbage collected at any time, even before it’s done.

python docs

Please review the link: https://textual.textualize.io/blog/2023/02/11/the-heisenbug-lurking-in-your-async-code/

@anio anio requested a review from a team as a code owner June 28, 2023 12:02
@anio
Copy link
Contributor Author

anio commented Jun 28, 2023

@microsoft-github-policy-service agree

@tracyboehrer tracyboehrer requested a review from aacebo October 11, 2023 19:55
@tracyboehrer tracyboehrer changed the title save a reference to created tasks, to avoid tasks disappearing fix: Save a reference to created tasks, to avoid tasks disappearing Jan 25, 2024
@tracyboehrer tracyboehrer merged commit 786650e into microsoft:main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

@aacebo aacebo Awaiting requested review from aacebo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anio @tracyboehrer