Skip to content

refactor: reorganize code and add full type hint #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 25, 2022
Merged

refactor: reorganize code and add full type hint #92

merged 5 commits into from
Sep 25, 2022

Conversation

@XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Sep 25, 2022 •
edited
Loading

Split from #83

  • Bump OpTree version to 0.2.0
  • Remove directory _src
  • Add full type hints

@XuehaiPan XuehaiPan requested a review from JieRen98 September 25, 2022 07:32
@XuehaiPan XuehaiPan self-assigned this Sep 25, 2022
JieRen98
JieRen98 previously approved these changes Sep 25, 2022
View reviewed changes
JieRen98
JieRen98 reviewed Sep 25, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022 •
edited
Loading

Codecov Report

Base: 72.72% // Head: 73.20% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (e97603e) compared to base (bc7a1c5).
Patch coverage: 69.89% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   72.72%   73.20%   +0.47%     
==========================================
  Files          33       33              
  Lines        1430     1515      +85     
==========================================
+ Hits         1040     1109      +69     
- Misses        390      406      +16
Flag Coverage Δ
unittests 73.20% <69.89%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/visual.py 10.60% <20.00%> (ø)
torchopt/utils.py 28.82% <28.82%> (ø)
torchopt/transform.py 81.07% <73.80%> (ø)
torchopt/accelerated_op/__init__.py 22.72% <75.00%> (ø)
torchopt/optim/meta/base.py 62.50% <82.35%> (ø)
torchopt/linalg.py 91.78% <85.71%> (ø)
torchopt/base.py 78.26% <90.00%> (ø)
torchopt/optim/base.py 85.18% <92.00%> (ø)
torchopt/__init__.py 100.00% <100.00%> (ø)
torchopt/accelerated_op/adam_op.py 75.00% <100.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

JieRen98
JieRen98 previously approved these changes Sep 25, 2022
View reviewed changes
@XuehaiPan XuehaiPan merged commit af6d24c into metaopt:main Sep 25, 2022
@XuehaiPan XuehaiPan deleted the refactor branch September 25, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JieRen98 JieRen98 JieRen98 left review comments

Assignees

@XuehaiPan XuehaiPan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XuehaiPan @codecov-commenter @JieRen98