Skip to content

feat: add AdamW optimizer #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Sep 5, 2022
Merged

feat: add AdamW optimizer #44

merged 33 commits into from
Sep 5, 2022

Conversation

@Benjamin-eecs
Copy link
Member

@Benjamin-eecs Benjamin-eecs commented Jul 27, 2022

#16

@Benjamin-eecs Benjamin-eecs changed the title Add adamw optimizer Add AdamW optimizer Jul 27, 2022
@Benjamin-eecs Benjamin-eecs linked an issue Jul 27, 2022 that may be closed by this pull request
[Feature Request] AdamW support #16
Closed
1 task
@Benjamin-eecs Benjamin-eecs added the enhancement New feature or request label Jul 27, 2022
@Benjamin-eecs Benjamin-eecs added this to the 0.5.0 milestone Jul 27, 2022
@Benjamin-eecs Benjamin-eecs self-assigned this Jul 27, 2022
@XuehaiPan XuehaiPan added the feature New feature label Jul 27, 2022
@Benjamin-eecs Benjamin-eecs marked this pull request as ready for review August 4, 2022 19:32
@Benjamin-eecs Benjamin-eecs changed the title Add AdamW optimizer feat: AdamW optimizer Sep 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022 •
edited
Loading

Codecov Report

Merging #44 (0f5c90a) into main (218d4e0) will increase coverage by 0.20%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   62.20%   62.41%   +0.20%     
==========================================
  Files          26       28       +2     
  Lines         987     1075      +88     
==========================================
+ Hits          614      671      +57     
- Misses        373      404      +31
Flag Coverage Δ
unittests 62.41% <66.66%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/_src/base.py 80.00% <ø> (ø)
torchopt/_src/hook.py 35.71% <0.00%> (ø)
torchopt/_src/optimizer/adam.py 100.00% <ø> (ø)
torchopt/_src/optimizer/meta/adam.py 87.50% <ø> (ø)
torchopt/_src/optimizer/meta/base.py 33.33% <ø> (ø)
torchopt/_src/optimizer/meta/rmsprop.py 87.50% <ø> (ø)
torchopt/_src/optimizer/meta/sgd.py 85.71% <ø> (ø)
torchopt/_src/optimizer/rmsprop.py 100.00% <ø> (ø)
torchopt/_src/optimizer/sgd.py 100.00% <ø> (ø)
torchopt/_src/transform.py 75.87% <55.55%> (-4.36%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

XuehaiPan
XuehaiPan previously approved these changes Sep 5, 2022
View reviewed changes
@XuehaiPan XuehaiPan changed the title feat: AdamW optimizer feat: add AdamW optimizer Sep 5, 2022
@XuehaiPan XuehaiPan merged commit 7e7efda into metaopt:main Sep 5, 2022
@Benjamin-eecs Benjamin-eecs deleted the feature/adamw branch September 5, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuehaiPan XuehaiPan XuehaiPan approved these changes

Assignees

@Benjamin-eecs Benjamin-eecs

Labels

enhancement New feature or request feature New feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

[Feature Request] AdamW support

3 participants

@Benjamin-eecs @codecov-commenter @XuehaiPan