Plumb reply_id into sendText and sendData #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
I'm sorry to have let this languish so long. things look reasonable to me, so as long as CI doesn't turn up any issues this looks ready to merge to me |
Contributor
|
ugh, that one error in the CI is I think fixed in master. I'll just go ahead and merge it (doing this from my phone at present, heh) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also hit #688 when working on a test project, and given that the feature is basically already there, exposing it is rather simple and shouldn't cause anything to break (now or in the future).
Ofc, this is my first contribution to this project, so please lmk if I've messed something up!