Skip to content

fix(util): update waitForTraceRoute reset logic #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

fix(util): update waitForTraceRoute reset logic #785

merged 2 commits into from
Jun 9, 2025

Conversation

@grleblanc
Copy link
Contributor

@grleblanc grleblanc commented Jun 9, 2025

Fixes #784

ianmcorvidae
ianmcorvidae reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@ianmcorvidae ianmcorvidae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, otherwise LGTM

@codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.50%. Comparing base (9281c4a) to head (04a0ff6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/util.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   59.48%   59.50%   +0.01%     
==========================================
  Files          24       24              
  Lines        4122     4121       -1     
==========================================
  Hits         2452     2452              
+ Misses       1670     1669       -1
Flag Coverage Δ
unittests 59.50% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grleblanc grleblanc requested a review from ianmcorvidae June 9, 2025 23:19
@ianmcorvidae ianmcorvidae merged commit 0deb98b into meshtastic:master Jun 9, 2025
11 checks passed
@KB1RMA
Copy link

KB1RMA commented Jun 13, 2025

I've also been running this change locally off master for a little bit now and all is well so far.

Any plans to release this to the registry?

@KB1RMA KB1RMA mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianmcorvidae ianmcorvidae Awaiting requested review from ianmcorvidae

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] waitForTraceRotue reset does not do what is intended

3 participants

@grleblanc @KB1RMA @ianmcorvidae