Work around RTS/DTR serial reset issues on Windows #753
Conversation
|
|
Some devices (e.g. Heltec V3.1) are reset when the RTS or DTR pins are messed with, which means that without workarounds, Meshtastic CLI will cause a reset with any operation that opens the serial port. This behavior is documented in this PySerial issue: pyserial/pyserial#124 On Linux, we already handle this by disabling the HUPCL termios flag, which has the effect of preventing the offending lines being toggled. On Windows, setting the initial state of RTS and DTR before opening the port has a similar effect. Implement this workaround so that Meshtastic CLI can be used on Windows with these devices.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
==========================================
- Coverage 60.14% 60.13% -0.01%
==========================================
Files 24 24
Lines 4062 4066 +4
==========================================
+ Hits 2443 2445 +2
- Misses 1619 1621 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, sorry to get to this so slowly. I think this looks good, though I lack a windows machine to test it on, so I'll trust that this is beneficial on that platform for now. |
No worries at all - thank you for merging! 🙂 |
Some devices (e.g. Heltec V3.1) are reset when the RTS or DTR pins are messed with, which means that without workarounds, Meshtastic CLI will cause a reset with any operation that opens the serial port.
This behavior is documented in this PySerial issue: pyserial/pyserial#124
On Linux, we already handle this by disabling the HUPCL termios flag, which has the effect of preventing the offending lines being toggled. On Windows, setting the initial state of RTS and DTR before opening the port has a similar effect.
Implement this workaround so that Meshtastic CLI can be used on Windows with these devices.