-
Notifications
You must be signed in to change notification settings - Fork 23.2k
updated data collection permissions with strict Firefox version #43792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rebloor
merged 3 commits into
mdn:main
from
narasimhan-lakshmi:fix/data-collection-permission
Apr 15, 2026
+5
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why revert back to 58? (accident?)
Users will need to use 140, otherwise it won't work during addon submission due to usage of new
data_collection_permissionskey:https://extensionworkshop.com/documentation/develop/firefox-builtin-data-consent/#data-collection-experience-on-older-Firefox-versions
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they only need to set
strict_min_versionto 140 if they don't intend to provide a custom experience for early versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it now using
web-ext lintcommand available in theweb-exttool.If I set
strict_min_versionto 139 I get this warning:It's very likely people will see this warning upon submission to the addons store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you run the extension on Firefox 139, it doesn't display the built-in data-collection dialog. Hence, the point of Data collection experience on older Firefox versions. Extensions that collect data covered by the extension policies and want to run on 139 or earlier have to add a custom dialog for data consent (or disable data collection).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not talking about running Firefox, I'm only saying that submitting addon to the store with anything lower than 140 in the
strict_min_versionvalue will produce the warning above.And using lower number and removing the
data_collection_permissionswill produce also a warning:So the best way, that will not confuse new developers, is to use 140 and the data_collection_permissions as is in the example.
Only that will produce no warnings and everyone is happy :)
It's not like there is a reason to support anything below 140 anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is valid and can be used with any version of Firefox from 58 onward. Using the value of 140 could give the incorrect impression that
data_collection_permissionscan't be specified in extensions targeting versions before 140.