Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ sidebar: addonsidebar
"browser_specific_settings": {
"gecko": {
"id": "@addon-example",
"data_collection_permissions": {
"required": [
"none"
]
},
"strict_min_version": "58.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert back to 58? (accident?)
Users will need to use 140, otherwise it won't work during addon submission due to usage of new data_collection_permissions key:
https://extensionworkshop.com/documentation/develop/firefox-builtin-data-consent/#data-collection-experience-on-older-Firefox-versions

Copy link
Copy Markdown
Contributor

@rebloor rebloor Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they only need to set strict_min_version to 140 if they don't intend to provide a custom experience for early versions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it now using web-ext lint command available in the web-ext tool.
If I set strict_min_version to 139 I get this warning:

image

It's very likely people will see this warning upon submission to the addons store.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you run the extension on Firefox 139, it doesn't display the built-in data-collection dialog. Hence, the point of Data collection experience on older Firefox versions. Extensions that collect data covered by the extension policies and want to run on 139 or earlier have to add a custom dialog for data consent (or disable data collection).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not talking about running Firefox, I'm only saying that submitting addon to the store with anything lower than 140 in the strict_min_version value will produce the warning above.
And using lower number and removing the data_collection_permissions will produce also a warning:

image

So the best way, that will not confuse new developers, is to use 140 and the data_collection_permissions as is in the example.
Only that will produce no warnings and everyone is happy :)
It's not like there is a reason to support anything below 140 anymore, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is valid and can be used with any version of Firefox from 58 onward. Using the value of 140 could give the incorrect impression that data_collection_permissions can't be specified in extensions targeting versions before 140.

}
}
Expand Down
Loading