Chrome 145 Crashing reporting, crash report type#29475
Open
chrisdavidmills wants to merge 1 commit intomdn:mainfrom
Open
Chrome 145 Crashing reporting, crash report type#29475chrisdavidmills wants to merge 1 commit intomdn:mainfrom
chrisdavidmills wants to merge 1 commit intomdn:mainfrom
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 145 adds support for the Crash Reporting API; see https://chromestatus.com/feature/6228675846209536.
Most of the BCD for this API has already been added; however, I wanted to add a data point for the
crashreport type. The data for the different report types is contained under api.ReportingObserver.ReportingObserver.options_parameter.types_property, so I added it under there. This data is also used as the BCD for each report type dictionary; I'll need it when documentingCrashReportBody.This is a bit weird, as
crashreports aren't observed by reporting observers, but I think you can still specify them as a valid report type in the constructortypeslist.Test results and supporting details
Related issues