fix workflow(lint) settings #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Yellostone uses commander@13.1.0 and it expects node version ">=18", but lint workflow runs on node 14.21.3 - Update all actions to LTS version - Recent commits updated package-lock.json but workflow uses yarn.lock, delete yarn.lock.
- fix lint errors(unused variables)
- fix lint error to use const variables for never changed variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce
All recent failures of Github actions: lint.yml
Reason
Yellowstone uses commander@13.1.0 which expects node version ">=18", but lint workflow runs on Node 14.21.3
Also, there are many files that does not follow eslint rules.
What I did