-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix rstcheck failures #30810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rstcheck failures #30810
Conversation
| You can try out one of the various mouse rotation styles using: | ||
|
|
||
| .. code:: | ||
| .. code:: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: We typically use .. code-block:: not .. code::. I'm unclear whether this makes a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have one instance without a language, and it is not causing an error
| .. code-block:: |
Should I change this to code-block? Do we want it with or without syntax highlighting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it already has syntax highlighting in the stable docs.
https://matplotlib.org/stable/api/toolkits/mplot3d/view_angles.html#rotation-with-mouse
In all honesty probably just didn't understand it or didn't think it was that big a deal and was just trying to get the checker in 🤷♀️ |
story645
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this!
Fix rstcheck failures
PR summary
Recently the CI linting task has been failing in the rstcheck step, maybe because Sphinx just cut a major release. It seems the checker is now very strict about not duplicating references. This means not creating more than one handle for the same url and also not creating a handle with the same name as a subheading ("community" in
contribute.rst).PR checklist