-
-
Notifications
You must be signed in to change notification settings - Fork 412
Made table name under record title clickable (#4916) #4949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
radheshpai87
wants to merge
6
commits into
mathesar-foundation:develop
Choose a base branch
from
radheshpai87:fix/4916-make-table-name-clickable
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Made table name under record title clickable (#4916) #4949
radheshpai87
wants to merge
6
commits into
mathesar-foundation:develop
from
radheshpai87:fix/4916-make-table-name-clickable
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @radheshpai87, Some frontend tests are failing for your changes please look at https://github.com/mathesar-foundation/mathesar/blob/develop/mathesar_ui/README.md to fix these tests before we can review/merge these changes. |
Author
|
I have fixed the issues that were causing the tests to fail please check and let me know if anymore changes are to be made. |
pavish
requested changes
Nov 5, 2025
5 tasks
radheshpai87
added a commit
to radheshpai87/mathesar
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make table name under record page title clickable (#4916)
Fixes #4916
Summary
--color-table), shows underline on hover, and has a visible:focus-visibleoutline for keyboard users.mathesar_ui/src/pages/record/RecordPageContent.svelteTechnical details
HTML
Table name now rendered as:
(rendered inside the existing
RichTextslot)CSS
.table-name-link:text-decoration: none; cursor: pointer;color: var(--color-table, var(--entity-name-color, var(--color-record))); text-decoration: underline;:focus-visible: outline usingcolor-mix(...)based on the same variable;outline-offsetfor clarity.Accessibility
titleandaria-labelcan be used when desired; the component already supports adding these.Files modified
mathesar_ui/src/pages/record/RecordPageContent.svelteScreenshots
Checklist
developbranch of the repository.Developer Certificate of Origin
Developer Certificate of Origin