Fix make _.isNumber(NaN) return false and update tests #6012
+5,799
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Fix:
_.isNumber(NaN)now returnsfalseas expected (Fixes #5981)🐛 The Issue
In Lodash v4.17.21, the
_.isNumberfunction incorrectly returnstrueforNaN. This is problematic in scenarios where consumers of the library want to distinguish valid numbers fromNaN.Reference: Issue #5981
✅ The Fix
The
isNumberfunction has been updated to returnfalsewhen the input isNaN. The logic now ensures that:NaNvalues are filtered out.NaNvalues (e.g.,Object(NaN)) are also handled appropriately.🧪 Tests Updated
assert.strictEqual(_.isNumber(NaN), false);pnpm test.