Skip to content

Conversation

@mathiasbynens
Copy link
Contributor

Given the list of characters that are escaped already, I can’t think of a reason why you’d want/need to escape / in a quoted attribute value or an element’s content.

escape() is only meant to be used in these three situations:

<p>HERE</p>
<p data-foo="HERE"></p>
<p data-foo='HERE'></p>

Whoops, typo in commit message — to clarify, this is about the / character, not the \ character. I’ll fix the commit message upon mergin the pull (if it gets approved).

@mathiasbynens
Copy link
Contributor Author

If even @0x6d6172696f doesn’t see anything wrong with it, it must be safe: http://twitter.com/0x6d6172696f/status/207473713363435520

Then I'd say it's cool. Given that u+003C is being escaped as well

mathiasbynens added a commit that referenced this pull request Aug 29, 2013
mathiasbynens added a commit that referenced this pull request Sep 25, 2014
Ref. #18.


Former-commit-id: 82a29019daa15c83cb2159685ca5d575265cd902
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants