Fix: Return proper client error for invalid YAML template structure #13300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Converted to draft as I misunderstood the issue, will work on it later on. |
Contributor
|
This is awesome, thank you for at least starting this change! I look forward to seeing where it goes. Do you want my initial comments now or should I wait until you are happy with the PR? |
Contributor
Author
let's wait, I will remove draft status when ready. |
Contributor
Author
|
Ok I think it's ready for review now @simonrw. |
simonrw
approved these changes
Oct 28, 2025
Contributor
simonrw
left a comment
There was a problem hiding this comment.
This is great, thank you for your contribution. There are still some rough edges around the new engine and validation, so thank you for catching this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #12309
Add snapshot testing for CloudFormation stack creation with EC2 templates that include CloudFormation Init functionality.
Correctly raise an
ClientErrorwhen invalidyamlfile is provided.Changes
test_create_stack_from_templateyamlparser for cloudeformation engine.