Skip to content

Upgrade moto #13262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

Upgrade moto #13262

merged 3 commits into from
Oct 14, 2025

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Oct 14, 2025

Motivation

Follow-up from #13261, this PR upgrades the Moto dependencies and fix the small changes in API / regenerate snapshots for tests.

Changes

  • update moto-ext to 5.1.14.post34
  • fix backend attribute access in SES
  • regenerate snapshot for ACM

@bentsku bentsku self-assigned this Oct 14, 2025
@bentsku bentsku added aws:ses Amazon Simple Email Service aws:acm AWS Certificate Manager semver: patch Non-breaking changes which can be included in patch releases dependencies Pull requests that update a dependency file docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 14, 2025
@bentsku bentsku added this to the 4.10 milestone Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

    2 files  ±0    2 suites  ±0   8m 8s ⏱️ +6s
  532 tests ±0  480 ✅ ±0   52 💤 ±0  0 ❌ ±0 
1 064 runs  ±0  960 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 878d9dc. ± Comparison against base commit d1129bb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   15m 49s ⏱️ -11s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 878d9dc. ± Comparison against base commit d1129bb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 21s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 878d9dc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 39m 31s ⏱️
5 190 tests 4 693 ✅ 497 💤 0 ❌
5 196 runs  4 693 ✅ 503 💤 0 ❌

Results for commit 878d9dc.

♻️ This comment has been updated with latest results.

@bentsku bentsku mentioned this pull request Oct 14, 2025
Merged
Base automatically changed from upgrade-dependencies to main October 14, 2025 10:56
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   2h 0m 14s ⏱️ + 1m 3s
4 816 tests ±0  4 479 ✅ ±0  337 💤 ±0  0 ❌ ±0 
4 818 runs  ±0  4 479 ✅ ±0  339 💤 ±0  0 ❌ ±0 

Results for commit 878d9dc. ± Comparison against base commit d1129bb.

@bentsku bentsku marked this pull request as ready for review October 14, 2025 12:17
@bentsku bentsku requested a review from dfangl October 14, 2025 12:17
dfangl
dfangl approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

k-a-il
k-a-il approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bentsku bentsku merged commit 73e4f6c into main Oct 14, 2025
46 checks passed
@bentsku bentsku deleted the upgrade-moto branch October 14, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfangl dfangl dfangl approved these changes

@k-a-il k-a-il k-a-il approved these changes

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni viren-nadkarni is a code owner

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@sannya-singal sannya-singal Awaiting requested review from sannya-singal sannya-singal is a code owner

Assignees

@bentsku bentsku

Labels

aws:acm AWS Certificate Manager aws:ses Amazon Simple Email Service dependencies Pull requests that update a dependency file docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

4 participants

@bentsku @dfangl @k-a-il