Skip to content

CFN: add validation to FnSplit #13244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

CFN: add validation to FnSplit #13244

merged 2 commits into from
Oct 13, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Oct 8, 2025 •
edited by simonrw
Loading

Motivation

This PR adds a validation to the arguments passed to Fn::Split. Some customers are finding the new CFn engine hard to use due to the lack of proper validation error messages.

Example:

!Split [!Ref TemplateParameter]

Should be used like:

!Split ["-", !Ref TemplateParameter]

Changes

  • Add validation when evaluating Fn:Split

Testing

  • AWS Validated test

Notes

related to #13217

Part of UNC-31

@pinzon pinzon added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   16m 24s ⏱️ +3s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fecdf0f. ± Comparison against base commit 69ed784.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   36m 3s ⏱️
585 tests 471 ✅ 114 💤 0 ❌
587 runs  471 ✅ 116 💤 0 ❌

Results for commit fecdf0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fecdf0f. ± Comparison against base commit 69ed784.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 33s ⏱️
609 tests 496 ✅ 113 💤 0 ❌
615 runs  496 ✅ 119 💤 0 ❌

Results for commit fecdf0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results - Alternative Providers

584 tests   330 ✅  25m 48s ⏱️
  1 suites  254 💤
  1 files      0 ❌

Results for commit fecdf0f.

♻️ This comment has been updated with latest results.

@pinzon pinzon added this to the Playground milestone Oct 8, 2025
@pinzon pinzon marked this pull request as ready for review October 9, 2025 01:34
@simonrw simonrw mentioned this pull request Oct 10, 2025
Merged
@pinzon pinzon force-pushed the cp/cfn/v2/validate-split branch from 46fc152 to fecdf0f Compare October 10, 2025 17:31
@pinzon pinzon added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Oct 10, 2025
@pinzon pinzon merged commit ab567e5 into main Oct 13, 2025
45 checks passed
@pinzon pinzon deleted the cp/cfn/v2/validate-split branch October 13, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

aws:cloudformation:v2 Issues related to the V2 CloudFormation engine aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

3 participants

@pinzon @simonrw