Skip to content

DynamoDB: Add support for WarmThroughput parameters #13235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 13, 2025
Merged

DynamoDB: Add support for WarmThroughput parameters #13235

merged 8 commits into from
Oct 13, 2025
+657 −91

Conversation

@viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Oct 7, 2025 •
edited
Loading

Background

DynamoDB supports Warm Throughput feature. Only recently, Terraform starting making use of these parameters to identify the status of the table from 6.13.0 onwards.

DynamoDB Local does not yet return these parameters, and this has started causing Terraform to do into indefinite polling loop.

Changes

This PR adds support for warm through put parameters to the DynamoDB provider.

Tests

AWS validated tests are included.

Related

Closes #13140

Closes PNX-232

@viren-nadkarni viren-nadkarni self-assigned this Oct 7, 2025
@viren-nadkarni viren-nadkarni added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 7, 2025
@viren-nadkarni viren-nadkarni force-pushed the ddb-create-table-parity branch 2 times, most recently from 104dc3f to 8871c27 Compare October 7, 2025 12:39
@github-actions
Copy link

github-actions bot commented Oct 7, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   15m 33s ⏱️ -39s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 921611e. ± Comparison against base commit 658d6fb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 22s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 921611e. ± Comparison against base commit 658d6fb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025 •
edited
Loading

Test Results - Alternative Providers

57 tests   - 1 310   53 ✅  - 658   1m 10s ⏱️ - 38m 46s
 1 suites  -     4    4 💤  - 652 
 1 files    -     4    0 ❌ ±  0 

Results for commit 921611e. ± Comparison against base commit 658d6fb.

This pull request removes 1312 and adds 2 tests. Note that renamed tests count towards both. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_autoexpand_capability_requirement
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_non_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_update_refreshes_template_metadata
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_create_existing
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_invalid_params
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_missing_stackname
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_no_changes
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_nonexisting
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_without_parameters
…

tests.aws.services.dynamodb.test_dynamodb.TestDynamoDB ‑ test_table_crud
tests.aws.services.dynamodb.test_dynamodb.TestDynamoDB ‑ test_table_warm_throughput

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni force-pushed the ddb-create-table-parity branch from 8871c27 to d8dcf16 Compare October 7, 2025 13:24
@github-actions
Copy link

github-actions bot commented Oct 7, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   34m 55s ⏱️ - 2h 3m 32s
1 244 tests  - 3 943  1 176 ✅  - 3 514  68 💤  - 429  0 ❌ ±0 
1 250 runs   - 3 943  1 176 ✅  - 3 514  74 💤  - 429  0 ❌ ±0 

Results for commit 921611e. ± Comparison against base commit 658d6fb.

This pull request removes 3945 and adds 2 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.dynamodb.test_dynamodb.TestDynamoDB ‑ test_table_crud
tests.aws.services.dynamodb.test_dynamodb.TestDynamoDB ‑ test_table_warm_throughput

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   17m 37s ⏱️ - 1h 41m 51s
1 220 tests  - 3 593  1 151 ✅  - 3 325  69 💤  - 268  0 ❌ ±0 
1 222 runs   - 3 593  1 151 ✅  - 3 325  71 💤  - 268  0 ❌ ±0 

Results for commit 921611e. ± Comparison against base commit 658d6fb.

This pull request removes 3595 and adds 2 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.dynamodb.test_dynamodb.TestDynamoDB ‑ test_table_crud
tests.aws.services.dynamodb.test_dynamodb.TestDynamoDB ‑ test_table_warm_throughput

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni changed the title DynamoDB: Add WarmThroughput field to DescribeTable response DynamoDB: Add support for WarmThroughput parameters Oct 8, 2025
@viren-nadkarni viren-nadkarni force-pushed the ddb-create-table-parity branch from e67aa33 to 921611e Compare October 9, 2025 09:52
@viren-nadkarni viren-nadkarni marked this pull request as ready for review October 9, 2025 10:38
giograno
giograno approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@giograno giograno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Thanks for tackling this!

tests/aws/services/dynamodb/test_dynamodb.validation.json
},
"tests/aws/services/dynamodb/test_dynamodb.py::TestDynamoDB::test_dynamodb_get_batch_items": {
"last_validated_date": "2023-08-23T14:33:58+00:00"
"last_validated_date": "2025-10-08T12:37:20+00:00",
Copy link
Member

@giograno giograno Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kudos for re-validating the tests!

@viren-nadkarni viren-nadkarni merged commit 098d7a1 into main Oct 13, 2025
40 checks passed
@viren-nadkarni viren-nadkarni deleted the ddb-create-table-parity branch October 13, 2025 09:47
@bentsku bentsku mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giograno giograno giograno approved these changes

Assignees

@viren-nadkarni viren-nadkarni

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: DynamoDB DescribeTable response missing WarmThroughput field causes Terraform AWS Provider v6.13.0+ infinite polling loop

3 participants

@viren-nadkarni @giograno