Skip to content

fix(kinesis): Add account and region context when using connect_to #13211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix(kinesis): Add account and region context when using connect_to #13211

merged 1 commit into from
Sep 30, 2025

Conversation

@gregfurman
Copy link
Contributor

@gregfurman gregfurman commented Sep 30, 2025

Motivation

In order to target the correct kinesis mock server, we need to pass the account ID and region name from the request context.

Changes

  • Pass the account_id and region_name from the request context when creating a kinesis client using connect_to(...)

@gregfurman gregfurman added this to the 4.9 milestone Sep 30, 2025
@gregfurman gregfurman self-assigned this Sep 30, 2025
@gregfurman gregfurman added type: bug Bug report aws:kinesis Amazon Kinesis semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes and removed docs: skip Pull request does not require documentation changes labels Sep 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Test Results - Preflight, Unit

22 281 tests  ±0   20 538 ✅ ±0   16m 15s ⏱️ -4s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 5bd7325. ± Comparison against base commit 8a4c5b7.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 26s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5bd7325. ± Comparison against base commit 8a4c5b7.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   44m 10s ⏱️ - 1h 15m 40s
1 268 tests  - 3 525  1 205 ✅  - 3 252  63 💤  - 273  0 ❌ ±0 
1 270 runs   - 3 525  1 205 ✅  - 3 252  65 💤  - 273  0 ❌ ±0 

Results for commit 5bd7325. ± Comparison against base commit 8a4c5b7.

This pull request removes 3525 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 0m 42s ⏱️
1 292 tests 1 232 ✅ 60 💤 0 ❌
1 298 runs  1 232 ✅ 66 💤 0 ❌

Results for commit 5bd7325.

@gregfurman gregfurman merged commit 11b7585 into main Sep 30, 2025
64 of 71 checks passed
@gregfurman gregfurman deleted the fix/kinesis/resource-crud branch September 30, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmacvicar dmacvicar dmacvicar approved these changes

Assignees

@gregfurman gregfurman

Labels

aws:kinesis Amazon Kinesis docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases type: bug Bug report

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@gregfurman @dmacvicar