Skip to content

fix sqs dev endpoint to show invisible fifo messages correctly #13196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2025
Merged

fix sqs dev endpoint to show invisible fifo messages correctly #13196

merged 2 commits into from
Sep 26, 2025

Conversation

@thrau
Copy link
Member

@thrau thrau commented Sep 25, 2025

Motivation

This fixes a long-standing issue of the /_aws/sqs/messages endpoint not showing invisible messages correctly of FIFO queues. The issue was that we still made the assumption that queue.inflight holds all inflight messages. This is no longer true since fix message group id behavior in sqs fifo queues, since we reworked the way fifo queues keep track of inflight messages in #8238.

I slightly change how the messages are collected for fifo queues, and now it works.

Changes

  • the /_aws/sqs/messages endpoint now correctly lists in-flight messages for FIFO queues

@thrau thrau added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Sep 25, 2025
@thrau thrau added this to the 4.9 milestone Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 277 tests  ±0   20 536 ✅ ±0   15m 26s ⏱️ -20s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c55ddfe. ± Comparison against base commit f93ee95.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 23s ⏱️ +5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c55ddfe. ± Comparison against base commit f93ee95.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 2m 49s ⏱️ - 55m 58s
3 193 tests  - 1 589  3 058 ✅  - 1 388  135 💤  - 201  0 ❌ ±0 
3 195 runs   - 1 589  3 058 ✅  - 1 388  137 💤  - 201  0 ❌ ±0 

Results for commit c55ddfe. ± Comparison against base commit f93ee95.

This pull request removes 1592 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sqs.test_sqs_backdoor.TestSqsDeveloperEndpoints ‑ test_fifo_list_messages_with_invisible_messages[domain]
tests.aws.services.sqs.test_sqs_backdoor.TestSqsDeveloperEndpoints ‑ test_fifo_list_messages_with_invisible_messages[path]
tests.aws.services.sqs.test_sqs_backdoor.TestSqsDeveloperEndpoints ‑ test_fifo_list_messages_with_invisible_messages[standard]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 32m 6s ⏱️ - 1h 6m 25s
3 217 tests  - 1 939  3 085 ✅  - 1 575  132 💤  - 364  0 ❌ ±0 
3 223 runs   - 1 939  3 085 ✅  - 1 575  138 💤  - 364  0 ❌ ±0 

Results for commit c55ddfe. ± Comparison against base commit f93ee95.

This pull request removes 1942 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sqs.test_sqs_backdoor.TestSqsDeveloperEndpoints ‑ test_fifo_list_messages_with_invisible_messages[domain]
tests.aws.services.sqs.test_sqs_backdoor.TestSqsDeveloperEndpoints ‑ test_fifo_list_messages_with_invisible_messages[path]
tests.aws.services.sqs.test_sqs_backdoor.TestSqsDeveloperEndpoints ‑ test_fifo_list_messages_with_invisible_messages[standard]

♻️ This comment has been updated with latest results.

@thrau thrau mentioned this pull request Sep 25, 2025
Merged
baermat
baermat approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! A go from my side, once my question is addressed

@thrau thrau merged commit 1d26fe7 into main Sep 26, 2025
39 checks passed
@thrau thrau deleted the fix-sqs-backdoor-fifo-visibility branch September 26, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baermat baermat baermat approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@thrau @baermat