Skip to content

CFN: fix for dynamic ref when value is a number #13194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

CFN: fix for dynamic ref when value is a number #13194

merged 1 commit into from
Sep 25, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Sep 25, 2025 •
edited
Loading

Motivation

  • This PR fixes an issue in the pipeline caused by perform_dynamic_reference_lookup returning a number in certain occasions.

Changes

  • convert returning type to string as the type annotation suggests

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Test Results - Preflight, Unit

22 277 tests  ±0   20 536 ✅ ±0   16m 20s ⏱️ +9s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3fa534e. ± Comparison against base commit 339ad5c.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 20s ⏱️ +7s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3fa534e. ± Comparison against base commit 339ad5c.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 20s ⏱️ - 1h 26m 3s
573 tests  - 4 208  458 ✅  - 3 987  115 💤  - 221  0 ❌ ±0 
575 runs   - 4 208  458 ✅  - 3 987  117 💤  - 221  0 ❌ ±0 

Results for commit 3fa534e. ± Comparison against base commit 339ad5c.

This pull request removes 4208 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   47m 34s ⏱️
597 tests 483 ✅ 114 💤 0 ❌
603 runs  483 ✅ 120 💤 0 ❌

Results for commit 3fa534e.

@pinzon pinzon marked this pull request as ready for review September 25, 2025 19:03
@pinzon pinzon requested a review from cloutierMat September 25, 2025 19:03
cloutierMat
cloutierMat approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Thanks for the jumping in on this!

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Test Results - Alternative Providers

572 tests   329 ✅  25m 53s ⏱️
  1 suites  243 💤
  1 files      0 ❌

Results for commit 3fa534e.

@pinzon pinzon merged commit f93ee95 into main Sep 25, 2025
43 checks passed
@pinzon pinzon deleted the cp/cfn/hot-fix/dynamic-ref-typing branch September 25, 2025 19:14
@alexrashed alexrashed added this to the 4.9 milestone Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@pinzon @cloutierMat @alexrashed