Skip to content

Add hot reload regression test cases for implicit behavior #13183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

Add hot reload regression test cases for implicit behavior #13183

merged 2 commits into from
Sep 23, 2025

Conversation

@joe4dev
Copy link
Member

@joe4dev joe4dev commented Sep 23, 2025 •
edited
Loading

Motivation

The heuristic in the AWS Toolkit integration (announced here) depends on the implicit assumption that it starts with hot-reloading (see code here). We should add a test to make that assumption explicit.

Changes

  • Add assertion for the CodeSha256 to start with hot-reloading
  • Add assertion for the GetFunction>Code>Location to return a valid file URI pointing to the local hot-reload path

sidenote: Path.from_uri requires Python 3.13 (https://docs.python.org/3/library/pathlib.html#pathlib.Path.from_uri)

disclaimer: I haven't tested the path assertion on Windows.

Testing

  1. Start LocalStack in container dev mode using python -m localstack.dev.run
  2. Run the test aws.services.lambda_.test_lambda_developer_tools.TestHotReloading.test_hot_reloading against the running container

@joe4dev joe4dev added this to the 4.9 milestone Sep 23, 2025
@joe4dev joe4dev self-assigned this Sep 23, 2025
@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Sep 23, 2025
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 258 tests  ±0   20 517 ✅ ±0   15m 30s ⏱️ - 1m 10s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 0a394fc. ± Comparison against base commit 4be950c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 19s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 0a394fc. ± Comparison against base commit 4be950c.

♻️ This comment has been updated with latest results.

@joe4dev joe4dev added the docs: skip Pull request does not require documentation changes label Sep 23, 2025
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   2h 3m 25s ⏱️ - 32m 40s
3 444 tests  - 1 604  3 220 ✅  - 1 346  224 💤  - 258  0 ❌ ±0 
3 450 runs   - 1 604  3 220 ✅  - 1 346  230 💤  - 258  0 ❌ ±0 

Results for commit 0a394fc. ± Comparison against base commit 4be950c.

This pull request removes 1604 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 34m 0s ⏱️ - 24m 6s
3 420 tests  - 1 254  3 192 ✅  - 1 160  228 💤  - 94  0 ❌ ±0 
3 422 runs   - 1 254  3 192 ✅  - 1 160  230 💤  - 94  0 ❌ ±0 

Results for commit 0a394fc. ± Comparison against base commit 4be950c.

This pull request removes 1254 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@joe4dev
Fix mount path assertion
0a394fc 
The test passed locally, but didn't match in CI: https://github.com/localstack/localstack/actions/runs/17940461254/job/51017715236?pr=13183#step:9:3229

```
/var/lib/localstack/tmp/hot-reload-342b262a
/tmp/localstack/tmp/hot-reload-342b262a
```

Using the `mount_path` should fix this issue in CI.
@joe4dev joe4dev marked this pull request as ready for review September 23, 2025 12:14
dfangl
dfangl approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to add an explicit assertion here!

@joe4dev joe4dev merged commit abb44e3 into main Sep 23, 2025
41 checks passed
@joe4dev joe4dev deleted the add-hot-reload-regression-test branch September 23, 2025 12:20
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@joe4dev joe4dev

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@joe4dev @dfangl @alexrashed