Skip to content

CFn: validate during get template #13139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

CFn: validate during get template #13139

merged 2 commits into from
Sep 15, 2025
+147 −0

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 12, 2025 •
edited
Loading

Motivation

Users have been experiencing issues when getting the template for a non-executed stack.

Changes

  • Validate that the stack name is provided if the change set name is provided and is not an ARN
  • Validate that the change set exists
  • Validate that the stack is found if the stack name is provided

@simonrw simonrw added this to the 4.9 milestone Sep 12, 2025
@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted docs: skip Pull request does not require documentation changes labels Sep 12, 2025
@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 125 tests  ±0   20 387 ✅ ±0   6m 37s ⏱️ +19s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a0b6dae. ± Comparison against base commit 515c19b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 4s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a0b6dae. ± Comparison against base commit 515c19b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 11s ⏱️ - 1h 20m 34s
564 tests  - 4 095  449 ✅  - 3 879  115 💤  - 216  0 ❌ ±0 
566 runs   - 4 095  449 ✅  - 3 879  117 💤  - 216  0 ❌ ±0 

Results for commit a0b6dae. ± Comparison against base commit 515c19b.

This pull request removes 4098 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.api.test_templates ‑ test_get_template_missing_resources_change_set
tests.aws.services.cloudformation.api.test_templates ‑ test_get_template_missing_resources_change_set_id
tests.aws.services.cloudformation.api.test_templates ‑ test_get_template_missing_resources_stack

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   47m 7s ⏱️
588 tests 474 ✅ 114 💤 0 ❌
594 runs  474 ✅ 120 💤 0 ❌

Results for commit a0b6dae.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Test Results - Alternative Providers

563 tests   330 ✅  24m 14s ⏱️
  1 suites  233 💤
  1 files      0 ❌

Results for commit a0b6dae.

♻️ This comment has been updated with latest results.

@simonrw simonrw marked this pull request as ready for review September 15, 2025 21:32
pinzon
pinzon approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

@simonrw simonrw merged commit d5914bf into main Sep 15, 2025
51 checks passed
@simonrw simonrw deleted the cfn/fix/get-template-non-existing-resource branch September 15, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrw @pinzon