CFn: tidy up legacy skip decorator #13130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

simonrw merged 4 commits into main from cfn/chore/refactor-legacy-skip-decorator

Sep 16, 2025

Contributor

simonrw commented Sep 11, 2025

Motivation

Our skip_if_v1_provider is not named well:

it mentions v1 rather than legacy
it says provider rather than engine

Also there is no longer a need to add a message

Changes

reword decorator
remove required message argument

simonrw added aws:cloudformation area: asf semver: patch review: merge when ready docs: skip labels

simonrw added this to the Playground milestone

github-actions bot commented Sep 11, 2025 •

edited

Loading

Test Results - Preflight, Unit

22 145 tests ±0 20 407 ✅ ±0 6m 20s ⏱️ -8s
1 suites ±0 1 738 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 60675b5. ± Comparison against base commit d5914bf.

♻️ This comment has been updated with latest results.

github-actions bot commented Sep 11, 2025 •

edited

Loading

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 5s ⏱️ -1s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 60675b5. ± Comparison against base commit d5914bf.

♻️ This comment has been updated with latest results.

github-actions bot commented Sep 11, 2025 •

edited

Loading

LocalStack Community integration with Pro

2 files 2 suites 34m 31s ⏱️
571 tests 456 ✅ 115 💤 0 ❌
573 runs 456 ✅ 117 💤 0 ❌

Results for commit 60675b5.

♻️ This comment has been updated with latest results.

github-actions bot commented Sep 11, 2025 •

edited

Loading

Test Results (amd64) - Integration, Bootstrap

5 files 5 suites 47m 43s ⏱️
595 tests 481 ✅ 114 💤 0 ❌
601 runs 481 ✅ 120 💤 0 ❌

Results for commit 60675b5.

♻️ This comment has been updated with latest results.

simonrw removed the area: asf label

simonrw modified the milestones: Playground, 4.9

github-actions bot commented Sep 11, 2025 •

edited

Loading

Test Results - Alternative Providers

570 tests 330 ✅ 24m 9s ⏱️
1 suites 240 💤
1 files 0 ❌

Results for commit 60675b5.

♻️ This comment has been updated with latest results.

simonrw marked this pull request as ready for review

September 11, 2025 14:18

simonrw requested review from dominikschubert and pinzon as code owners

September 11, 2025 14:18

pinzon approved these changes

View reviewed changes

Member

pinzon left a comment

Thanks for this 👍

simonrw removed the review: merge when ready label

simonrw marked this pull request as draft

September 11, 2025 14:35

simonrw added 4 commits

September 15, 2025 23:57


          Rename skip_if_v1_provider decorator

0a94728


          Reword skip message

0a0ba13


          Dont' provide default argument

22f7155


          Update after rebase

60675b5

simonrw force-pushed the cfn/chore/refactor-legacy-skip-decorator branch from b94416c to 60675b5 Compare

September 15, 2025 23:00

simonrw marked this pull request as ready for review

September 16, 2025 06:05

simonrw merged commit 81352c9 into main

43 checks passed

simonrw deleted the cfn/chore/refactor-legacy-skip-decorator branch

September 16, 2025 06:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws:cloudformation docs: skip semver: patch