Skip to content

SES: add snapshot test for describe_configuration_set with SNS destinations #12814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

SES: add snapshot test for describe_configuration_set with SNS destinations #12814

merged 1 commit into from
Sep 26, 2025

Conversation

@dmacvicar
Copy link
Contributor

@dmacvicar dmacvicar commented Jun 29, 2025 •
edited
Loading

Motivation

As reported in #12722, describe_configuration_set is missing SNS event destinations.

This is addressed in getmoto/moto#9023 and this PR complements the parity enhancement with a snapshot test.

Changes

Only tests.

Testing

  • Snapshot test to validate the destinations are there when setting them for a configuration set.

TODO

@dmacvicar dmacvicar self-assigned this Jun 29, 2025
@dmacvicar dmacvicar added the semver: patch Non-breaking changes which can be included in patch releases label Jun 29, 2025
@localstack-bot
Copy link
Contributor

localstack-bot commented Jun 29, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

localstack-bot
localstack-bot reviewed Jun 29, 2025
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from f699351 to 7684f3a Compare June 29, 2025 14:37
@dmacvicar
Copy link
Contributor Author

dmacvicar commented Jun 29, 2025

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Jun 29, 2025
@localstack-bot
@dmacvicar has signed the CLA in #12814
8f50364
@github-actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   2m 49s ⏱️ - 1h 58m 12s
169 tests  - 4 612  164 ✅  - 4 281  5 💤  - 331  0 ❌ ±0 
171 runs   - 4 612  164 ✅  - 4 281  7 💤  - 331  0 ❌ ±0 

Results for commit 4feeb9a. ± Comparison against base commit 15fc427.

This pull request removes 4613 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.ses.test_ses.TestSES ‑ test_describe_config_set_event_destinations

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 270 tests  ±0   20 529 ✅ ±0   16m 21s ⏱️ +52s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 4feeb9a. ± Comparison against base commit 15fc427.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ -11s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4feeb9a. ± Comparison against base commit 15fc427.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   12m 33s ⏱️ - 2h 27m 7s
193 tests  - 4 962  188 ✅  - 4 471   5 💤  - 491  0 ❌ ±0 
199 runs   - 4 962  188 ✅  - 4 471  11 💤  - 491  0 ❌ ±0 

Results for commit 4feeb9a. ± Comparison against base commit 15fc427.

This pull request removes 4963 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.ses.test_ses.TestSES ‑ test_describe_config_set_event_destinations

♻️ This comment has been updated with latest results.

@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from 7684f3a to 67618e2 Compare June 29, 2025 20:41
@alexrashed alexrashed added this to the 4.8 milestone Jul 23, 2025
@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from 67618e2 to aa59f83 Compare August 20, 2025 12:14
@alexrashed alexrashed modified the milestones: 4.8, 4.9 Sep 10, 2025
@dmacvicar dmacvicar marked this pull request as ready for review September 10, 2025 15:28
@dmacvicar dmacvicar marked this pull request as draft September 10, 2025 15:31
@dmacvicar dmacvicar force-pushed the 12722-ses-describe-config-set-event-destination branch from aa59f83 to 4feeb9a Compare September 25, 2025 15:14
@dmacvicar dmacvicar marked this pull request as ready for review September 26, 2025 06:37
alexrashed
alexrashed approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! Great to see this behavior implemented in moto directly being validated (and protected against any future regressions) here in our tests! 💯

@dmacvicar dmacvicar merged commit c6edf33 into main Sep 26, 2025
40 checks passed
@dmacvicar dmacvicar deleted the 12722-ses-describe-config-set-event-destination branch September 26, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@alexrashed alexrashed alexrashed approved these changes

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni viren-nadkarni is a code owner

Assignees

@dmacvicar dmacvicar

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@dmacvicar @localstack-bot @alexrashed