ASF: Mark optional params as such (X | None) #12614
Conversation
LocalStack Community integration with Pro 2 files 2 suites 1h 42m 1s ⏱️ Results for commit 218d504. ♻️ This comment has been updated with latest results. |
alexrashed
left a comment
There was a problem hiding this comment.
Small and concise change and directly as discussed in the other linked PRs / conversations!
Would it make sense to maybe also update the APIs directly here in the PR in a separate commit and in our downstream project right after merging this one, instead of mixing it with the weekly automatically scheduled execution of the update next Monday? :)
MEPalma
left a comment
There was a problem hiding this comment.
The extra annotation for SFN is definitely welcome, as is the possibility to use MyPy; thank you!
Just curious, are there plans/or would it be feasible for us to distinguish between Optional[X] and NotRequired[X]? I find that distinction quite useful.
@MEPalma I don't think I've ever used Do you find the distinction useful when invoking a |
Motivation
As discussed in #12588 - if we want to enable MyPy on the entire codebase, one of the first steps would be to make sure that the generated API has the correct types.
Changes
X | None = Noneinstead ofX = None)test_asf_providers.py::test_provider_signaturesto handle all variations of Optional/Union params