✨ Add stm32f1 Quadrature Encoder #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79344dc to
44d1685
Compare
kammce
requested changes
Aug 23, 2025
126455b to
4da9a53
Compare
kammce
requested changes
Aug 24, 2025
Member
kammce
left a comment
There was a problem hiding this comment.
This looks great! I see you are already adding docs for strong_ptr stuff. Once thats in and there are no other issues, I can approve this PR.
f71bcde to
2f2e34b
Compare
2f2e34b to
b8dcab2
Compare
kammce
requested changes
Aug 27, 2025
Member
|
Make sure to make a new commit with each change rather than amending (unless its a small typo in the commit). |
kammce
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in draft because it was tested before major refactoring.
Code compiles but will be tested soon.