set SSH timeout #6721
Merged
set SSH timeout #6721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethomson
reviewed
Jan 26, 2024
src/libgit2/transports/ssh_libssh2.c
Outdated
| } | ||
|
|
||
| if (git_socket_stream__connect_timeout > 0) { | ||
| libssh2_session_set_timeout(s, git_socket_stream__connect_timeout); |
Member
There was a problem hiding this comment.
We should inherit the git_socket_stream__connect_timeout from the socket stream. So we already have connection timeouts.
I think that for this, we want to use GIT_OPT_SET_SERVER_TIMEOUT. So I think that this should be git_socket_stream__timeout instead...
The connect timeout *does* apply to SSH connections (at least libssh2), so update the documentation appropriately.
Member
|
Looks great — I added one change to the docs that is related but independent. (They stated that the connect timeout was not supported for SSH, in fact, it is.) Thanks for the PR! 🎉 |
ethomson
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6708 ?